-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove keyword table from func is_reserved_ident
#6512
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request's title is not fulfill the requirements. @TCeason please update it 🙏. Valid format:
Valid types:
|
is_reserved_ident
@mergify update |
☑️ Nothing to do
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in the sql standard, table is supposed to be a reserved indent.
So I'm not sure if it's appropriate to use table directly as a non-reserved indent (there could be other potential problems? But I don't think of any at the moment).
Maybe those BI tools should follow the sql standard and use table
with `` instead of bare table
@andylokandy please take a review |
table can be a reversed keyword, but we should make it works when it's in projections? |
I think not only projection but also as a expr. |
Like this : table LIKE 'settings' in test sql |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Now we use the old parser to parse SQL first and then try to use planner v2.
So maybe some SQL will fail in planner v2 but success in planner v1.
In issue #6455 we find this bug. So in this pr, we fix it.
Fixes #6455