Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serde compatibility of null_count #6558

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Jul 9, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix fuse table meta data incompatibility introduced by PR #6067, by

  • rename ColumnStatistics::unset_bits to ColumnStatistics:null_count
  • and serde alias ColumnStatistics:null_count as ColumnStatistics::unset_bits

so that filed named null_count or unset_bits can both be de-serialized

Manually checked, that binary of this PR can read data generated by the commits that brought the incompatibility and the commit before that.

Namely, the following two commits.

commit e267f7ac91a169b5d9baa86311041ca94d5f503f
Merge: fef12ed99 ee005fa80
Author: BohuTANG <overred.shuttler@gmail.com>
Date:   Thu Jul 7 11:38:27 2022 +0800

    Merge pull request #6067 from dantengsky/feat-abandon-internal-parquet2-patches

    refactor: try abandon internal parquet2 patches

commit 19de25241095b0a3903dd0ca9f20f0ab60747db6
Author: lichuang <lichuang1982@gmail.com>
Date:   Thu Jul 7 11:33:58 2022 +0800

    fix: add watch txn unit test

Fixes #6556

@vercel
Copy link

vercel bot commented Jul 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 9, 2022 at 11:42AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 9, 2022
@dantengsky dantengsky marked this pull request as ready for review July 9, 2022 14:41
@dantengsky dantengsky requested a review from BohuTANG July 9, 2022 14:42
@BohuTANG BohuTANG merged commit a2e9f0e into databendlabs:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPCH Q18:Code: 1002, displayText = missing field unset_bits at line 1
2 participants