-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): pretty format for explain #6585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mergify
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Jul 12, 2022
leiysky
reviewed
Jul 12, 2022
Rest LGTM. |
Hi, there is a test failure:
https://github.com/datafuselabs/databend/runs/7313362524?check_suite_focus=true#step:3:464 |
Clippy is not happy: --> query/src/sql/planner/format/pretty_format.rs:53:61
|
53| (child_prefix.clone() + LAST_REGULAR_PREFIX).clone(),
| ^^^^^^^^help: remove this
|
= note: `-D clippy::redundant-clone` implied by `-D warnings`
note: this value is dropped without further use
--> query/src/sql/planner/format/pretty_format.rs:53:17
|
53| (child_prefix.clone() + LAST_REGULAR_PREFIX).clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
error: redundant clone
--> query/src/sql/planner/format/pretty_format.rs:54:51
|
54| (child_prefix + LAST_CHILD_PREFIX).clone(),
| ^^^^^^^^help: remove this
|
note: this value is dropped without further use
--> query/src/sql/planner/format/pretty_format.rs:54:17
|
54| (child_prefix + LAST_CHILD_PREFIX).clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone |
Signed-off-by: Enwei Jiao <jiaoew2011@gmail.com>
@mergify update |
cc @leiysky PTAL |
✅ Branch has been successfully updated |
Xuanwo
approved these changes
Jul 13, 2022
Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Enwei Jiao enwei.jiao@zilliz.com
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
support CockroachDB liked explain format
Fixes #5979