feat(expr): implement error report #6661

andylokandy · 2022-07-16T19:57:33Z

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

add spans for RawExpr and Expr
construct RawExpr for tests by parsing expression string, which help construct the correct span
type_check and Evaluator return Result instead of Option
improve readability for goldenfile outputs
add goldenfile test for type check errors

Tracked in #6547

vercel · 2022-07-16T19:57:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
databend	⬜️ Ignored (Inspect)		Jul 16, 2022 at 8:08PM (UTC)

feat(expr): implement error report

e6ee722

andylokandy mentioned this pull request Jul 16, 2022

Tracking issue for new expression framework #6547

Closed

33 tasks

mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 16, 2022

andylokandy requested review from leiysky and sundy-li July 16, 2022 20:06

improve readability

02de044

sundy-li approved these changes Jul 17, 2022

View reviewed changes

leiysky approved these changes Jul 17, 2022

View reviewed changes

mergify bot merged commit e57db65 into databendlabs:main Jul 17, 2022

andylokandy mentioned this pull request Jul 17, 2022

feat(expr): Support UInt32, UInt64, Int32, Int64 in new expression #6660

Merged