Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Google Cloud Storage as storage backend for databend #7171

Merged
merged 4 commits into from
Aug 18, 2022
Merged

feat: Google Cloud Storage as storage backend for databend #7171

merged 4 commits into from
Aug 18, 2022

Conversation

ClSlaid
Copy link
Contributor

@ClSlaid ClSlaid commented Aug 18, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. add GCS backend in common_storage
  2. add environment variable support for GCS
  3. some integrated tests for GCS

Related #7023

Related #7151

This PR does not introduce stage support for GCS.

Demonstrations

  • Running DataBend-Query on GCS:
    DataBend Query showing
  • Query with MySQL (MyCLI is a MySQL client with syntax highlighting):
    Query with mycli
  • Yes it's really on GCS, my proxy tells me :)
    proxy image

ClSlaid added 2 commits August 18, 2022 14:30
@ClSlaid
feat: implement GCS backend for Databend
0caf3f6 
1. implemented GCS operator
2. implemented GCS config for databend

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@ClSlaid
feat: add env-var support for GCS backend
7cc949f 
1. support environment variable support for GCS backend
    clap has some problem to deal with.

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@ClSlaid ClSlaid requested a review from BohuTANG August 18, 2022 07:33
@vercel
Copy link

vercel bot commented Aug 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 11:26AM (UTC)

@ClSlaid ClSlaid requested review from Xuanwo and BohuTANG and removed request for BohuTANG August 18, 2022 07:33
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 18, 2022
@Xuanwo Xuanwo requested a review from dantengsky August 18, 2022 07:36
Xuanwo
Xuanwo approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

@BohuTANG
Copy link
Member

Cool.
Then we can copy files from GCS?

@ClSlaid
Copy link
Contributor Author

ClSlaid commented Aug 18, 2022 •
edited
Loading

Cool. Then we can copy files from GCS?

This should work in theory, I'll give it a try.
Currently, nope

@Xuanwo
Copy link
Member

Xuanwo commented Aug 18, 2022

Then we can copy files from GCS?

This will be implemented in the following PRs.

@BohuTANG
Copy link
Member

It would be great to add a Google Cloud Storage tab to the deploy in the documentation:
https://databend.rs/doc/deploy/deploying-databend

@ClSlaid
refactor: fix tests
d98e77a 
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@mergify mergify bot merged commit b76ef86 into databendlabs:main Aug 18, 2022
@Xuanwo Xuanwo mentioned this pull request Aug 18, 2022
Closed
@BohuTANG
Copy link
Member

It would be great to add a Google Cloud Storage tab to the deploy in the documentation: https://databend.rs/doc/deploy/deploying-databend

cc @soyeric128

@ClSlaid
Copy link
Contributor Author

ClSlaid commented Aug 26, 2022

It would be great to add a Google Cloud Storage tab to the deploy in the documentation: https://databend.rs/doc/deploy/deploying-databend

cc @soyeric128

working on it.

@ClSlaid ClSlaid mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClSlaid @BohuTANG @Xuanwo