Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Retry fuse table write operations #8244

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 16, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: Retry fuse table write operations

Fix #8053

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Oct 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 16, 2022 at 5:28AM (UTC)

@Xuanwo Xuanwo marked this pull request as ready for review October 16, 2022 05:25
Signed-off-by: Xuanwo <github@xuanwo.io>
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Oct 16, 2022
@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 16, 2022

I'm testing this patch now.

@BohuTANG BohuTANG requested a review from dantengsky October 16, 2022 06:56
@BohuTANG BohuTANG merged commit 053a751 into databendlabs:main Oct 16, 2022
@Xuanwo Xuanwo deleted the write-retry branch October 16, 2022 14:51
.retry(ExponentialBackoff::default())
.when(|err| err.kind() == ErrorKind::Interrupted)
.notify(|err, dur| {
debug!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug! should error!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: operation interrupted during create table xx as select * from xx
2 participants