Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate deprecating set-output commands #8381

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

miles170
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Replace deprecating set-output command with $GITHUB_OUTPUT.

Closes #8342.

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 21, 2022 at 11:07AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2022

This pull request's title is not fulfill the requirements. @miles170 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@miles170 miles170 changed the title Migrate deprecating set-output commands in CI ci: migrate deprecating set-output commands Oct 21, 2022
@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label Oct 21, 2022
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for your contribution~

@miles170
Copy link
Contributor Author

miles170 commented Oct 21, 2022

It seems $GITHUB_OUTPUT doesn't play well with composite actions.
We might need to declare outputs for composite action (https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#outputs-for-composite-actions)

@miles170
Copy link
Contributor Author

Error: System.ArgumentException: Unexpected type 'NullToken' encountered while reading 'outputs'. The type 'MappingToken' was expected.

I assume this error implies that we must fill output_id.

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@mergify mergify bot merged commit f5bb626 into databendlabs:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Deprecate save-state and set-output commands in CI
3 participants