Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expr): move expressoin test to function-v2 #8397

Merged
merged 8 commits into from
Oct 22, 2022

Conversation

andylokandy
Copy link
Collaborator

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Fixes #issue

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 22, 2022 at 5:21AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 21, 2022
@andylokandy andylokandy requested a review from sundy-li October 21, 2022 20:36
@sundy-li
Copy link
Member

Use make lint to keep the code style.

@BohuTANG
Copy link
Member

Diff in /workspace/src/query/expression/tests/it/kernel.rs at line 17:
 use common_datavalues::ChunkRowIndex;
 use common_expression::types::DataType;
 use common_expression::types::NumberDataType;
+use common_expression::utils::ColumnFrom;
 use common_expression::Chunk;
 use common_expression::Column;
 use common_expression::ColumnFrom;
Diff in /workspace/src/query/expression/tests/it/kernel.rs at line 23:
 use common_expression::Value;
-use common_expression::utils::ColumnFrom;
 use goldenfile::Mint;

@andylokandy
Copy link
Collaborator Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2022

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

@andylokandy andylokandy merged commit aeac1b7 into databendlabs:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants