Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arithmatic expression support #71

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

notauserx
Copy link
Contributor

@notauserx notauserx commented Nov 19, 2024

Related to #12

@b41sh b41sh self-requested a review November 19, 2024 14:50
@b41sh
Copy link
Member

b41sh commented Dec 2, 2024

@notauserx thanks for your contribution, seems almost OK for me, please add some unit test cases for this feature.

@notauserx
Copy link
Contributor Author

I will get back to this next week

@b41sh b41sh changed the title wip: add arithmatic expression support feat: add arithmatic expression support Dec 10, 2024
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notauserx LGTM, thanks for your contribution.

@b41sh b41sh merged commit ace7386 into databendlabs:main Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants