Fix(mysql): Invaild column definitions lead to incorrect mariadb-client behavior #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Mar 30, 2022
Signed-off-by: Ye Sijun <junnplus@gmail.com>
sundy-li
reviewed
Mar 30, 2022
| // and will be removed in a future version. | ||
| // The mysql command line tool issues one of these commands after switching databases with USE <DB>. | ||
| // Return a invalid column definitions lead to incorrect mariadb-client behaviour, | ||
| // see https://github.com/datafuselabs/databend/issues/4439 |
There was a problem hiding this comment.
But will this make incorrect to old mysql client behavior?
There was a problem hiding this comment.
Not returning column definitions is acceptable behavior for the client. column information is used as completion, no return is better than invalid.
I also tested mysql-client 5.7 locally, it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ye Sijun junnplus@gmail.com
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
databendlabs/databend#4429