Add a test showing bug in merge if variables are used for keys #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since merge happens first, before variable resolution, two jobs are seen as different.
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
pietern
approved these changes
Jan 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
## Changes
Move mutator.Merge{JobClusters,JobParameters,JobTasks,PipelineClusters}
after variable resolution. This helps with the case when key contains a
variable.
@pietern mentioned here
#2101 (review)
it should be safe.
## Tests
Existing acceptance that was capturing the bug is updated with corrected
output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since merge happens first, before variable resolution, the two jobs are seen as different.
I also updated override/job_cluster/script to include more of the output.