Use regular expressions for testdiff replacements #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
requested review from
andrewnester,
shreyas-goenka and
denik
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Jan 15, 2025
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Jan 15, 2025
|
Integration test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replacement was split between the type
ReplacementContextand theReplaceOutputfunction. The latter also ran a couple of regular expressions. This change consolidates them such that it is up to the caller to compose the set of replacements to use.This change is required to accommodate UUID replacement in #2146.