PythonMutator: Fix relative path error #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
pietern
reviewed
Jan 29, 2025
| @@ -120,7 +126,7 @@ func TestPythonMutator_loadResources(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, []dyn.Location{ | |||
| { | |||
| File: "src/examples/job1.py", | |||
| File: pathlib.Join(rootPath, "src/examples/job1.py"), | |||
There was a problem hiding this comment.
I suspect you need to use filepath here as well, or it won't test equal on Windows.
There was a problem hiding this comment.
👍 , I keep forgetting which one is which
pietern
reviewed
Jan 29, 2025
| @@ -166,11 +166,11 @@ func TestLoadOutput(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestParsePythonLocations(t *testing.T) { | |||
| expected := dyn.Location{File: "foo.py", Line: 1, Column: 2} | |||
| expected := dyn.Location{File: "/tmp/my_project/foo.py", Line: 1, Column: 2} | |||
There was a problem hiding this comment.
You can run filepath.Clean to make is platform native.
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
@pietern I've updated comments for relative vs. absolute paths and added more tests covering both cases |
pietern
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix relative path errors in the Python mutator that was failing during deployment since v0.239.1.
Before that:
As a result, the bundle was deployed, but the deployment state wasn't updated.
Tests
Unit tests, adding acceptance tests in #2254