Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TestServer from acceptance to libs/testserver #2255

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jan 28, 2025

Changes

Just a move, no changes. As recommended here: #2226 (comment)

Tests

N/A

Copy link
Contributor

@denik denik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should move handlers as well?

Then testserver can be used instead of mocks in regular unit tests.

We can also test the test server itself with regular unit tests.

@denik
Copy link
Contributor

denik commented Jan 29, 2025

This is just a refactor, as recommended here: #2226 (comment)

nit: "refactor" could mean many things, more specific desc would be better: "Move TestServer unchanged from acceptance to libs/testserver".

@denik denik changed the title Add library for testserver Move TestServer from acceptance to libs/testserver Jan 29, 2025
@shreyas-goenka
Copy link
Contributor Author

Do you think we should move handlers as well?

Maybe later IMO. Since it's a function for acceptance tests, it's not really a functionality of the test server itself.

Then testserver can be used instead of mocks in regular unit tests.

Yeah, it can be a follow-up for when we need it. This sounds independent of what just creating the library.

@shreyas-goenka shreyas-goenka added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 124515e Jan 29, 2025
9 checks passed
@shreyas-goenka shreyas-goenka deleted the move-to-testserver branch January 29, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants