Added timeout to w.clusters.ensure_cluster_running()
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Retry on `OperationFailed` errors, same as in Java SDK
judahrand
force-pushed
the
ensure-cluster-running
branch
from
e8c0e64
to
2fe1293
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 53.73% 53.72% -0.02%
==========================================
Files 33 33
Lines 19332 19349 +17
==========================================
+ Hits 10389 10396 +7
- Misses 8943 8953 +10
☔ View full report in Codecov by Sentry. |
nfx
reviewed
Jul 11, 2023
databricks/sdk/mixins/compute.py
Outdated
| @@ -203,16 +209,25 @@ def select_node_type(self, | |||
| return nt.node_type_id | |||
| raise ValueError("cannot determine smallest node type") | |||
|
|
|||
| def ensure_cluster_is_running(self, cluster_id: str): | |||
| def ensure_cluster_is_running(self, cluster_id: str) -> compute.ClusterDetails: | |||
There was a problem hiding this comment.
why do you need cluster details to be returned? this will have to be adjusted across all SDKs
There was a problem hiding this comment.
It doesn't have to 🤷♂️ Just seemed more useful given that we have it than returning None.
Do you want me to revert that commit?
There was a problem hiding this comment.
@judahrand could you address this comment?
There was a problem hiding this comment.
Sorry! I'd forgotten to follow up on this. Done now.
This was requested in order to match up with the SDKs in other languages. This reverts commit 3f04d7c.
judahrand
force-pushed
the
ensure-cluster-running
branch
from
2932d2c
to
743252c
Compare
nfx
approved these changes
Aug 2, 2023
nfx
changed the title
w.clusters.ensure_cluster_running()
Merged
mgyucht
added a commit
that referenced
this pull request
Aug 2, 2023
mgyucht
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This picks up where #118 left off.
Tests
make testrun locallymake fmtapplied