Support older versions of urllib3 and Databricks Runtime with regards to DEFAULT_METHOD_WHITELIST change to DEFAULT_ALLOWED_METHODS
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 53.24% 53.24%
=======================================
Files 32 32
Lines 19151 19154 +3
=======================================
+ Hits 10197 10199 +2
- Misses 8954 8955 +1
☔ View full report in Codecov by Sentry. |
mgyucht
changed the title
nfx
changed the title
urllib3 and Databricks Runtime with regards to DEFAULT_METHOD_WHITELIST change to DEFAULT_ALLOWED_METHODS
pietern
approved these changes
Jul 18, 2023
Merged
nfx
added a commit
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the SDK to tolerate urllib3 < 1.26.0. In these versions of urllib3, Retry class's
DEFAULT_ALLOWED_METHODSwas calledDEFAULT_METHOD_WHITELIST, and the parameter in Retry's constructor was changed frommethod_whitelisttoallowed_methods. With this change, users using older versions of DBR (like the 7.3 LTS) can still use the current version of the SDK, even though the version of urllib3 is old.This change can be reverted when we no longer need to support urllib3 < 1.26.0 (i.e. after DBR 10.4 LTS, which is EOL on March 18, 2025).
Test