Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added connection_pool_size configuration property (preview) #276

Merged
merged 4 commits into from
Aug 10, 2023

Commits on Aug 8, 2023

  1. Added connection_pool_size configuration property (preview)

    We have three things that are configurable from `requests` connection pooling perspective:
    
    * `pool_connections` - Number of urllib3 connection pools to cache before discarding the least recently used pool. Python requests default value is 10. This PR increases it to 20.
    * `pool_maxsize` - The maximum number of connections to save in the pool. Improves performance in multithreaded situations. For now, we're setting it to the same value as connection_pool_size.
    * `pool_block` - If pool_block is False, then more connections will are created, but not saved after the first use. Block when no free connections are available. urllib3 ensures that no more than pool_maxsize connections are used at a time. Prevents platform from flooding. By default, requests library doesn't block. We start with blocking.
    
    This PR introduces `connection_pool_size` configuration property, which sets `pool_connections` and `pool_maxsize` to the same value. If not set, it uses 20 instead of default 10.
    nfx committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    07c0212 View commit details
    Browse the repository at this point in the history
  2. fmt

    nfx committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d3fa59f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    565dc68 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. rename

    nfx committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6ed5b70 View commit details
    Browse the repository at this point in the history