Add get_workspace_id to WorkspaceClient #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 57.89% 57.92% +0.03%
==========================================
Files 44 45 +1
Lines 27956 27988 +32
==========================================
+ Hits 16185 16213 +28
- Misses 11771 11775 +4 ☔ View full report in Codecov by Sentry. |
hectorcast-db
approved these changes
Feb 9, 2024
mgyucht
added a commit
that referenced
this pull request
Feb 15, 2024
This is a patch release with two small changes: * Add `get_workspace_id()` to WorkspaceClient ([#537](#537)). Bugfix: * Create a deepcopy of config when creating workspace client from account client ([#542](#542)). This fixes an issue where `AccountClient` instances would stop working after calling `get_workspace_client()`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There are times when it is especially useful to get the workspace ID for the current workspace client. Currently, the workspace ID for the current workspace is exposed as a header in the SCIM Me API call. We'll expose this through a get_workspace_id() method, caching the workspace ID for the lifetime of the client.
In the future, we may add a meta service for exposing information about the current account/workspace. At that point, we can migrate off of this somewhat hacky approach.
Ports databricks/databricks-sdk-go#808 to the Python SDK.
Tests
make testrun locallymake fmtapplied