Fix auth tests for windows.

[parthban-db]

Changes

Fix auth tests for windows.

• Added a powershell script as bash script doesn't run on windows
• change 'COMSPEC' enviornment variable to run commands on powershell
• Use 'USERPROFILE' instead of 'HOME' as it is alternative of 'HOME' in windows

Tests

• make test run locally
• make fmt applied
• relevant integration tests applied

[mgyucht]

To fix test_config_corrupt_config, we need to make two changes:

1. fix line 42 of conftest.py, where we expect forward slash as separator but should use os.sep.
2. The actual expected message in the at-raises annotation of the test needs to use backslashes instead of forward-slashes. I believe you can do something like:

msg = '...'
if os.name == 'nt':
  msg.replace('/', '\\')
@raises(msg)
def test_config_corrupt_config(...):
...

[mgyucht]

I'm not familiar with this variable, what is it used for? Do we only need to set this environment variable when configuring Path?

[parthban-db]

This basically points to the command line interpreter by default windows program run on cmd. But we are running a powershell script to mock the az so we need to run it on powershell.

[mgyucht]

Ah understood, and this is only needed for tests that run our mock az command.

[mgyucht]

Is __tests__ still needed?

[parthban-db]

in line 219 of test_auth.py, We are pointing the PATH to some garbage place such that It will not find the az command. I am currently not passing any argument related to path in set_az_path. Because in rest of the cases the path is fixed. thats why I needed the __tests__. what are your suggestions regarding this?

[mgyucht]

It's alright, more of a nit not to import things that aren't used, but if it is still used I just missed it. We can leave as-is.

[mgyucht]

Interesting that you don't need to change the direction of the slashes here?

[parthban-db]

I didn't find anything on internet regarding this. But maybe it fixes the path before setting the variable.

[mgyucht]

This is a little bit weird since it means we will have to change all \ to / in test assertions, which is why I preferred customizing the message itself depending on the OS. Not a big deal though, as these test cases change rarely and only one has a \\ in the exception message now.

[mgyucht]

This is fine, thanks for the fixes!