[Fix] Do not specify --tenant flag when fetching managed identity access token from the CLI #748
+109
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
approved these changes
Sep 5, 2024
|
This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details. Running from downstreams #467 |
|
This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details. Running from downstreams #467 |
tanmay-db
added a commit
that referenced
this pull request
Sep 16, 2024
### New Features and Improvements * Support Models in `dbutils.fs` operations ([#750](#750)). ### Bug Fixes * Do not specify --tenant flag when fetching managed identity access token from the CLI ([#748](#748)). * Fix deserialization of 401/403 errors ([#758](#758)). * Use correct optional typing in `WorkspaceClient` for `mypy` ([#760](#760)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
### New Features and Improvements * Support Models in `dbutils.fs` operations ([#750](#750)). ### Bug Fixes * Do not specify --tenant flag when fetching managed identity access token from the CLI ([#748](#748)). * Fix deserialization of 401/403 errors ([#758](#758)). * Use correct optional typing in `WorkspaceClient` for `mypy` ([#760](#760)).
aravind-segu
pushed a commit
to aravind-segu/databricks-sdk-py
that referenced
this pull request
Sep 18, 2024
…ess token from the CLI (databricks#748) ## Changes Ports databricks/databricks-sdk-go#1021 to the Python SDK. The Azure CLI's az account get-access-token command does not allow specifying --tenant flag if it is authenticated via the CLI. Fixes databricks#742. ## Tests Unit tests ensure that all expected cases are treated as managed identities. - [ ] `make test` run locally - [ ] `make fmt` applied - [ ] relevant integration tests applied
aravind-segu
pushed a commit
to aravind-segu/databricks-sdk-py
that referenced
this pull request
Sep 18, 2024
### New Features and Improvements * Support Models in `dbutils.fs` operations ([databricks#750](databricks#750)). ### Bug Fixes * Do not specify --tenant flag when fetching managed identity access token from the CLI ([databricks#748](databricks#748)). * Fix deserialization of 401/403 errors ([databricks#758](databricks#758)). * Use correct optional typing in `WorkspaceClient` for `mypy` ([databricks#760](databricks#760)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ports databricks/databricks-sdk-go#1021 to the Python SDK.
The Azure CLI's az account get-access-token command does not allow specifying --tenant flag if it is authenticated via the CLI.
Fixes #742.
Tests
Unit tests ensure that all expected cases are treated as managed identities.
make testrun locallymake fmtapplied