Use show table extended with table name list for get_catalog. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
requested review from
zhengruifeng,
allisonwang-db and
andrefurlan-db
| except dbt.exceptions.RuntimeException as e: | ||
| errmsg = getattr(e, "msg", "") | ||
| if ( | ||
| "[SCHEMA_NOT_FOUND]" in errmsg |
There was a problem hiding this comment.
If there is an error code in the error message, will we get the error message details as well ("Database ... not found")?
There was a problem hiding this comment.
The error message was changed:
[SCHEMA_NOT_FOUND] The schema <schemaName> cannot be found. Verify the spelling and correctness of the schema and catalog.
If you did not qualify the name with a catalog, verify the current_schema() output, or qualify the name with the correct catalog.
To tolerate the error on drop use DROP SCHEMA IF EXISTS.
|
|
||
| from dbt.adapters.spark.column import SparkColumn | ||
|
|
||
|
|
||
| @dataclass | ||
| class DatabricksColumn(SparkColumn): | ||
| TYPE_LABELS: ClassVar[Dict[str, str]] = { | ||
| "LONG": "BIGINT", |
There was a problem hiding this comment.
Why do we need this?
There was a problem hiding this comment.
This is a port of dbt-labs/dbt-spark#358.
allisonwang-db
approved these changes
Dec 16, 2022
|
Thanks! merging. |
ueshin
added a commit
that referenced
this pull request
Dec 16, 2022
### Description Uses `show table extended` with table name list for `get_catalog`. - Running `describe table extended` for all tables could be slower than `show table extended` with table name list. - Statistics that will appear in the generated docs are not included in `describe table extended`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
show table extendedwith table name list forget_catalog.describe table extendedfor all tables could be slower thanshow table extendedwith table name list.describe table extended.