-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DiffSuppressFunc for databricks_model_serving
resource
#2813
Conversation
But with the |
@alexott the problem is on Azure, where GPU serving is not enabled, the API returns empty |
and yeah, then we'll have GCP |
integration tests passed |
@nkvuong can we do the following instead: common.MustSchemaPath(m, "config", "served_models", "workload_type").Computed = true
common.MustSchemaPath(m, "config", "served_models", "workload_type").Optional = true That way, if the user doesn't specify, we fall back to the API default (which could be empty, as in Azure), and if they remove the value, it would keep its original value. I'm just so confused by DiffSuppressFunc... I'm going to try to repro now and use this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move forward with this as-is. I think we need to revisit how we use Computed/Optional vs DiffSuppressFunc in the future; in the meantime, let's just add a comment here, and merge.
Codecov Report
@@ Coverage Diff @@
## master #2813 +/- ##
==========================================
- Coverage 84.75% 84.65% -0.10%
==========================================
Files 150 151 +1
Lines 13086 13145 +59
==========================================
+ Hits 11091 11128 +37
- Misses 1394 1411 +17
- Partials 601 606 +5
|
Changes
Closes #2811
Tests
make test
run locallyinternal/acceptance