more test coverage

databrickslabs · Oct 2, 2024 · 9b35060 · 9b35060
1 parent be59a8f
commit 9b35060
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/databricks/labs/ucx/source_code/sql/sql_parser.py b/src/databricks/labs/ucx/source_code/sql/sql_parser.py
@@ -62,8 +62,8 @@ def find_all(self, klass: type[E]) -> Iterator[E]:
 
 class SqlParser:
 
-    @staticmethod
-    def walk_expressions(sql_code: str, callback: Callable[[SqlExpression], Iterable[T]]) -> Iterable[T]:
+    @classmethod
+    def walk_expressions(cls, sql_code: str, callback: Callable[[SqlExpression], Iterable[T]]) -> Iterable[T]:
         try:
             expressions = parse(sql_code, read='databricks')
             for expression in expressions:

diff --git a/tests/unit/source_code/sql/test_sql_parser.py b/tests/unit/source_code/sql/test_sql_parser.py
@@ -0,0 +1,9 @@
+import pytest
+from sqlglot import ParseError
+
+from databricks.labs.ucx.source_code.sql.sql_parser import SqlParser
+
+
+def test_raises_exception_with_unsupported_sql():
+    with pytest.raises(ParseError):
+        list(SqlParser.walk_expressions("XSELECT * from nowhere", lambda _: []))