Let migrate-acls command run as collection
#2655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
feat/account-level
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 2/2 passed, 13s total Running from acceptance #5910 |
JCZuurmond
changed the title
migrate-acls command to run as collectionmigrate-acls command run as collection
## Changes Adds support for extracting DirectFileSystemAccess records from workspace queries ### Linked issues Resolves #2350 ### Functionality - [x] added a new table `directfs_in_queries` - [x] added a new view `directfs` unioning `directfs_in_paths` with the above ### Tests - [x] added unit tests - [x] manually tested schema upgrade:  Integration with ExperimentalWorkflowLinter will be done in a separate PR --------- Co-authored-by: Eric Vergnaud <eric.vergnaud@databricks.com> Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com> Co-authored-by: Andrew Snare <asnare@users.noreply.github.com>
## Changes Let `validate-groups-membership` command to run as collection ### Linked issues Resolves #2613 ### Functionality - [x] modified existing command: `databricks labs ucx validate-groups-membership` ### Tests - [x] manually tested - [x] added unit tests - [ ] ~added integration tests~ : Covering after #2507
## Changes Let `migrate-dbsql-dashboards` command to run as collection ### Linked issues Resolves #2612 ### Functionality - [x] modified existing command: `databricks labs ucx migrate-dbsql-dashboards` ### Tests - [x] manually tested - [x] added unit tests - [ ] ~added integration tests~ : Covering after #2507
## Changes Let `validate-external-locations` command to run as collection ### Linked issues Resolves #2608 ### Functionality - [x] modified existing command: `databricks labs ucx migrate-locations` ### Tests - [x] manually tested - [x] added unit tests - [ ] ~added integration tests~ : Covering after #2507
## Changes Our code implements 'replace' methods on some dataclasses with no benefit over the builtin method. This PR fixes that. ### Linked issues None ### Functionality None ### Tests - [x] ran unit tests --------- Co-authored-by: Eric Vergnaud <eric.vergnaud@databricks.com>
## Changes LocalCodeLinter is unable to normalize python code at notebook cell level This PR fixes the issue ### Linked issues None ### Functionality None ### Tests - [x] manually tested running `make solacc` on files that fail in CI --------- Co-authored-by: Eric Vergnaud <eric.vergnaud@databricks.com>
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
I messed something up with the commit history, will fix |
|
Preference goes to: #2664 |
JCZuurmond
deleted the
feat/let-migrate-acls-command-run-on-collection-of-workspaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let
migrate-aclscommand to run as collectionLinked issues
Resolves #2611
Functionality
databricks labs ucx migrate-aclsTests
added integration tests: Covering after [TECH DEBT]: Merge functionality for running ucx accross workspaces #2507