Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure: test_running_real_remove_backup_groups_job #2692

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented Sep 20, 2024

Changes

Verify the "remove-workspace-local-backup-groups" finished successfully before checking the group was deleted

Linked issues

(Hopefully) Resolves #2691. The eventual consistency of the groups API makes testing difficult.

Tests

  • modified integration tests: test_running_real_remove_backup_groups_job

@JCZuurmond JCZuurmond added migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade internal this pull request won't appear in release notes labels Sep 20, 2024
@JCZuurmond JCZuurmond self-assigned this Sep 20, 2024
@JCZuurmond JCZuurmond requested a review from a team as a code owner September 20, 2024 07:27
Copy link

✅ 91/91 passed, 1 skipped, 1h40m21s total

Running from acceptance #6009

Copy link
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit ea85f24 into main Sep 20, 2024
6 checks passed
@nfx nfx deleted the fix/test-failure-running-real-remove-backup-groups-job branch September 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal this pull request won't appear in release notes migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: test_running_real_remove_backup_groups_job
3 participants