diff does not honour "helm.sh/resource-policy: keep" #246
Labels
Comments
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I have the same problem. |
|
I also just ran into this. I know it may be kind of an edge case, but it might be worth re-opening; even if just for visibility. |
|
I have the same issue, in our case with secrets which are generated only if they do not already exist (check via lookup if one exists, if so use that, else generate a new one). |
phooijenga
added a commit
to phooijenga/helm-diff
that referenced
this issue
Mar 19, 2024
The annotation `helm.sh/resource-policy: keep` instructs Helm to skip deleting this resource when a Helm operation would result in its deletion. As the resource is not actually deleted, exclude it from the generated diff.
phooijenga
added a commit
to phooijenga/helm-diff
that referenced
this issue
Mar 22, 2024
The annotation `helm.sh/resource-policy: keep` instructs Helm to skip deleting this resource when a Helm operation would result in its deletion. As the resource is not actually deleted, exclude it from the generated diff.
yxxhero
pushed a commit
that referenced
this issue
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a deployment which used an older version of helm, which defines the namespace as a YAML object in the helm chart. We want to upgrade to removing this as is the defined method in helm 3, so have added
helm.sh/resource-policy: keepas an annotation, however when I runhelm diffon the chart, it shows it will be removed. This is intended functionality as the YAML no longer exists, but could a note be added to the output of the diff noting to the user that this is annotated so it will not be deleted?The text was updated successfully, but these errors were encountered: