Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HELM_DIFF_IGNORE_UNKNOWN_FLAGS seems to be ignored in v3.9.2 #537

Closed
deiga opened this issue Jan 19, 2024 · 3 comments · Fixed by #538
Closed

HELM_DIFF_IGNORE_UNKNOWN_FLAGS seems to be ignored in v3.9.2 #537

deiga opened this issue Jan 19, 2024 · 3 comments · Fixed by #538
Assignees
@yxxhero

Comments

@deiga
Copy link
Contributor

deiga commented Jan 19, 2024

Hello,

We have added --force to helm diff upgrade a few weeks ago and added HELM_DIFF_IGNORE_UNKNOWN_FLAGS=true to the environment.

Today our client auto-updated to 3.9.2 from 3.8.1 and we are getting this error in our CI.

[2024-01-18T19:15:22.172Z] + helm diff -C7 upgrade --allow-unreleased --force --values helm/values-eu-qa.yaml --values helm/values-pr.yaml ...

[2024-01-18T19:15:22.172Z] Error: unknown flag: --force

[2024-01-18T19:15:22.172Z] Usage:

[2024-01-18T19:15:22.172Z]   diff upgrade [flags] [RELEASE] [CHART]
@deiga
Copy link
Contributor Author

deiga commented Jan 19, 2024

We reverted back to 3.8.1 and it works again

@yxxhero
Copy link
Collaborator

yxxhero commented Jan 19, 2024

@deiga PR is welcome.

@yxxhero yxxhero mentioned this issue Jan 19, 2024
Merged
@yxxhero
Copy link
Collaborator

yxxhero commented Jan 20, 2024

#499

@yxxhero yxxhero self-assigned this Jan 26, 2024
@mumoshu mumoshu mentioned this issue Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yxxhero yxxhero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: HELM_DIFF_IGNORE_UNKNOWN_FLAGS ignored issue yxxhero/helm-diff
2 participants
@deiga @yxxhero