Remake dry-run=server optional #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
commented
Jan 27, 2024
mumoshu
commented
Jan 27, 2024
mumoshu
commented
Jan 27, 2024
mumoshu
force-pushed
the
redo-dry-run-server-opt
branch
2 times, most recently
from
b7200d9 to
ada86a8
Compare
This is a follow-up on #499 which redoes it without relying on DisableParsing. DisableParsing turned out to break far many things than I imagined!
mumoshu
force-pushed
the
redo-dry-run-server-opt
branch
from
ada86a8 to
38df431
Compare
mumoshu
commented
Jan 27, 2024
mumoshu
commented
Jan 27, 2024
mumoshu
commented
Jan 27, 2024
mumoshu
commented
Jan 27, 2024
Signed-off-by: yxxhero <aiopsclub@163.com>
|
@mumoshu test locally. all is ok. |
yxxhero
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #499 which redoes it without relying on cobra's DisableFlagParsing. DisableFlagParsing turned out to break far many things than I imagined!
Fixes #536
Ref #537 #538