Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply bunt color config based on no-color for dyff output #586

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

eata219
Copy link
Contributor

@eata219 eata219 commented Apr 3, 2024

Hi, this is my first time to create PR.
I just cherry-pick the commit below because I cannot get any reponses.
kingli-crypto@52327b6

Thank you.


allowing dyff to display color correctly
fixes #467

allowing dyff to display color correctly
fixes databus23#467
@eata219 eata219 force-pushed the fix-dyff-when-piped branch from b7fd18b to f77e6cf Compare April 3, 2024 07:43
@eata219 eata219 changed the title feat: apply bunt color config based on no-color feat: apply bunt color config based on no-color for dyff output Apr 3, 2024
@eata219 eata219 marked this pull request as ready for review April 3, 2024 07:47
@yxxhero
Copy link
Collaborator

yxxhero commented Apr 3, 2024

@eata219 what's the benifits? thanks so much.

@yxxhero
Copy link
Collaborator

yxxhero commented Apr 3, 2024

@eata219 please fix ci issue.

@eata219
Copy link
Contributor Author

eata219 commented Apr 3, 2024

@yxxhero

@eata219 what's the benifits? thanks so much.

As described in #467 , the result of --output dyff is not colorized when helm-diff process is piped.

You can reproduce this by helm diff --output dyff .... | less -R .
Also using helmfile, the result of helmfile diff --output dyff ... is not colorized.

Using less is useful when the output is long.
Also helmfile is useful tool for deploying many charts.

This PR will colorize the result of dyff output in above situations.

@yxxhero
Copy link
Collaborator

yxxhero commented Apr 3, 2024

@eata219 thanks for your answer. please fix ci issue.

@eata219
Copy link
Contributor Author

eata219 commented Apr 3, 2024

@yxxhero Thanks. I pushed a commit and it will be fixed.

@eata219
Copy link
Contributor Author

eata219 commented Apr 3, 2024

Hmm.., I have no idea about this CI result.
https://github.com/databus23/helm-diff/actions/runs/8537723234/job/23390981666?pr=586
Does this error randomly occur? Cloud you retry it?

@yxxhero
Copy link
Collaborator

yxxhero commented Apr 3, 2024

@eata219 go mod tidy

@eata219
Copy link
Contributor Author

eata219 commented Apr 3, 2024

@yxxhero thanks!

@yxxhero
Copy link
Collaborator

yxxhero commented Apr 3, 2024

import 'github.com/gonvenience/bunt' is not allowed from list 'main'

@yxxhero yxxhero merged commit c34feed into databus23:master Apr 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No color when piping dyff output
3 participants