Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Text filters' section #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

marijane
Copy link
Contributor

The sentence introducing this section ended with the clause "and reinstate the text facet on the scientificName column", but the exercise that follows expects this facet to be closed. I removed this part of the sentence to make the exercise flow more logically from the preceding text.

The sentence introducing this section ended with the clause " and reinstate the text facet on the `scientificName` column", but the exercise that follows expects this facet to be closed. I removed this part of the sentence to make the exercise flow more logically from the preceding text.
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/OpenRefine-ecology-lesson/compare/md-outputs..md-outputs-PR-301

The following changes were observed in the rendered markdown documents:

 05-filter-exclude-sort.md | 2 +-
 md5sum.txt                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-22 07:05:15 +0000

github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@bencomp
Copy link
Contributor

bencomp commented Sep 23, 2023

Thanks for this, @marijane. I agree that removing this part of the sentence improves the text flow. But then the screen shot already includes the text facet too. Could you move it inside the solution of the exercise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants