This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Allow /dev devices for NVMe SSD's and vagrant disks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spjmurray
force-pushed
the
master
branch
2 times, most recently
from
873efa1
to
de4e4aa
Compare
|
I think this is likely fixed in 7e2117a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVMe devices can't be configured with SCSI addresses, because they aren't SCSI devices.
Also, adding extra disks in different vagrant providers or VM platforms results in different SCSI addresses, while the /dev device names are consistent.
This is tested to work in both vagrant and on physical machines with journaling on Intel P3700 NVMe SSD's.