Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas param to TxOpts #28

Merged
merged 14 commits into from
Feb 5, 2024
Merged

Add gas param to TxOpts #28

merged 14 commits into from
Feb 5, 2024

Conversation

yoshidan
Copy link
Contributor

@yoshidan yoshidan commented Jan 4, 2024

this PR allows gasPrice and gasTipCap/gasFeeCap to be specified as options

Tasks

  • legacy tx (use eth_gasPrice)
  • dynamic tx (use eth_feeHistroy)
  • dynamic tx fallback (leave to BoundContract)

Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
@yoshidan yoshidan changed the title Add gas param opts Add gas param to TxOpts Jan 4, 2024
Signed-off-by: yoshidan <naohiro.y@gmail.com>
@yoshidan yoshidan marked this pull request as ready for review January 9, 2024 11:46
@yoshidan yoshidan requested a review from siburu January 10, 2024 00:02
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Signed-off-by: yoshidan <naohiro.y@gmail.com>
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshidan Great work, thank you!

@siburu siburu merged commit 1c384bf into datachainlab:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants