Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up to yui-relayer@v0.5.1 (ibc-go@v8.2.0) #40

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

siburu
Copy link
Contributor

@siburu siburu commented Apr 24, 2024

Blocked by #39

Bump up dependencies

  • yui-relayer to v0.5.1
  • ibc-go to v8.2.0
  • cosmos-sdk to v0.50.5
  • go-ethereum to v1.14.0
  • and so on

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu siburu marked this pull request as ready for review April 26, 2024 20:35
@bluele
Copy link
Member

bluele commented Apr 27, 2024

@siburu Thanks! Could you update to the abi of ibc-solidity v0.3.27?

@siburu
Copy link
Contributor Author

siburu commented Apr 27, 2024

@bluele OK. Should I update ibc-solidity to the latest BEFORE this PR?

@bluele
Copy link
Member

bluele commented Apr 27, 2024

I think it should be included in this PR. Because the minimum version of ibc-solidity corresponding ibc-go v8 is v0.3.27.

go.mod Outdated
go 1.20
go 1.21

toolchain go1.22.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with go mod, but is this directive required since go 1.21? If yes, is there any reason why that toolchain minor version differs from the go directive one?

Copy link
Contributor Author

@siburu siburu Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bluele Thank you.
As far as I understand, toolchain is optional and only takes effect when it's in the main module's go.mod.
Therefore I should delete this line.

done 69993e9

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siburu Thanks, LGTM👍

@siburu siburu merged commit c08b4a6 into datachainlab:main Apr 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants