Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Set only the fields of CallMsg required for each tx type #42

Conversation

siburu
Copy link
Contributor

@siburu siburu commented May 1, 2024

No description provided.

@bluele
Copy link
Member

bluele commented May 2, 2024

Does this fix #41? @siburu

@siburu
Copy link
Contributor Author

siburu commented May 2, 2024

@bluele Sorry, but no. I'm still investigating that.

@siburu siburu marked this pull request as draft May 2, 2024 03:26
@siburu siburu force-pushed the fix/both-gasprice-and-maxfeepergas-or-maxpriorityfeepergas-specificied branch from f48c622 to eb9d810 Compare May 2, 2024 04:07
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu siburu force-pushed the fix/both-gasprice-and-maxfeepergas-or-maxpriorityfeepergas-specificied branch from eb9d810 to f01f289 Compare May 2, 2024 04:47
@siburu siburu requested a review from bluele May 2, 2024 05:44
@siburu siburu marked this pull request as ready for review May 2, 2024 05:44
@siburu siburu changed the title [BUGFIX] Set only one of GasPrice and GasTipCap+GasFeeCap to CallMsg [BUGFIX] Set only the fields of CallMsg required for each tx type May 2, 2024
@siburu
Copy link
Contributor Author

siburu commented May 2, 2024

@bluele Now this PR is ready for review.
I confirmed that this fixes #41 through this work datachainlab/yui-relayer-build#26

Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siburu LGTM👍

@siburu siburu merged commit 58c30b0 into datachainlab:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants