Skip to content

Commit

Permalink
Skip failing custom dc tests. (#4820)
Browse files Browse the repository at this point in the history
  • Loading branch information
keyurva authored Dec 27, 2024
1 parent 62e394b commit c8a8c66
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 0 deletions.
4 changes: 4 additions & 0 deletions server/webdriver/cdc_tests/autopush/cdc_base_webdriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
from server.webdriver.base import WebdriverBaseTest
from server.webdriver.cdc_tests.base import CDC_AUTOPUSH_URL

# Shared tests that don't work in custom DC are skipped with this reason.
# Any skipped test should be noted in b/386405593, fixed and unskipped subsequently.
SKIPPED_TEST_REASON = "Not working in custom DC. See b/386405593"


class CdcAutopushTestBase(WebdriverBaseTest):
"""Base class for CDC Autopush webdriver tests."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import unittest

from server.webdriver.cdc_tests.autopush.cdc_base_webdriver import \
CdcAutopushTestBase
from server.webdriver.cdc_tests.autopush.cdc_base_webdriver import \
SKIPPED_TEST_REASON
from server.webdriver.shared_tests.place_explorer_i18n_test import \
PlaceI18nExplorerTestMixin


class TestPlaceExplorerI18n(PlaceI18nExplorerTestMixin, CdcAutopushTestBase):
"""Class to test the i18n place explorer page for Custom DC. Tests come from PlaceI18nExplorerTestMixin."""

@unittest.skip(reason=SKIPPED_TEST_REASON)
def test_explorer_redirect_place_explorer_keeps_locale(self):
super().test_explorer_redirect_place_explorer_keeps_locale()
8 changes: 8 additions & 0 deletions server/webdriver/cdc_tests/autopush/place_explorer_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import unittest

from server.webdriver.cdc_tests.autopush.cdc_base_webdriver import \
CdcAutopushTestBase
from server.webdriver.cdc_tests.autopush.cdc_base_webdriver import \
SKIPPED_TEST_REASON
from server.webdriver.shared_tests.place_explorer_test import \
PlaceExplorerTestMixin


class TestPlaceExplorer(PlaceExplorerTestMixin, CdcAutopushTestBase):
"""Class to test the place explorer page for Custom DC. Tests come from PlaceExplorerTestMixin."""

@unittest.skip(reason=SKIPPED_TEST_REASON)
def test_explorer_redirect_place_explorer(self):
super().test_explorer_redirect_place_explorer()

0 comments on commit c8a8c66

Please sign in to comment.