Consolidate custom DC Docker image release scripts #4527
Conversation
| WEBSITE_PROD_TAG="prod" | ||
|
|
||
| # Tag to be added to the CDC image that is found. | ||
| STABLE_CANDIDATE_TAG="stable-candidate" |
There was a problem hiding this comment.
We eventually want to tag as "stable". Is "stable-candidate" temporary until we have tagging working fully?
There was a problem hiding this comment.
The way I envisioned the workflow was (1) automatically tag stable-candidate (2) verify tests pass against it (3) manually change the tag from stable-candidate to stable. Thoughts?
There was a problem hiding this comment.
I'm thinking that since autopush sanity would've already kicked in, we'd know before hand if the version had any issues. WDYT?
There was a problem hiding this comment.
It would have kicked in, but it might not have succeeded. I think it'd be good to have a manual verification of test results before finalizing that the image is stable.
There was a problem hiding this comment.
SG.
A couple questions:
- Are you thinking we'd have a cloud run instance pointing to stable-candidate and use that for testing?
- We need to tag the git commit with the
customdc_stabletag as well. Would we be tagging it withcustomdc_stable_candidatefirst and update tocustomdc_stableafter the manual verification?
| ###### BEGIN CONFIG ###### | ||
|
|
||
| # Tag of the website commit that we'll attempt to find a matching CDC image for. | ||
| WEBSITE_PROD_TAG="prod" |
There was a problem hiding this comment.
Can the script take the website tag as a parameter? Also, does it need to be a tag or can we get it to work with a commit sha as well?
There was a problem hiding this comment.
Sure, both are doable, though it's more work and maintenance to have the script be able to do more things. What will the standard workflow be?
There was a problem hiding this comment.
The tag would either be based on a prod tag or on a specific commit. It'd be good to support both.
There was a problem hiding this comment.
Ok, working on adding this now.
|
@hqpho Looking through my old PRs- is this still relevant? |
|
sounds good! thanks @hqpho |
hqpho
changed the title
This will be used to build + tag stable after the stable branch is updated: https://paste.googleplex.com/5895977398697984
An alternate approach would be to just keep the shared script and have the deployment yamls call it with arguments. Lmk what you think!