Sv explorer redirect #4641
Closed
Sv explorer redirect #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could we trigger the "onclick" handler for that stat var instead? then it could work for timeline too and wouldn't rely on the url format of those specific tools |
|
Yes sounds good. It looks like we just needed to trigger the the togglePath method in the handler. I modified it and put it in a new PR. closing this one. |
gmechali
added a commit
that referenced
this pull request
Sep 30, 2024
This PR is a repeat of #4641 but with a different approach that is much simpler and works for all tools reusing the statVarSearch. Following [comment](#4641 (comment)). See screencasts SV Explorer: Before: https://screencast.googleplex.com/cast/NTg2NzQ1ODIxNTgwNDkyOHxlNmY4Y2RiMy0wOQ After: https://screencast.googleplex.com/cast/NTI2ODYzMjQ2NzY2ODk5MnxmNDg0Mzk2NC05Nw Map Explorer: Before: https://screencast.googleplex.com/cast/NTI5MDk5NzE2NzY4NTYzMnw4OTAxMWQxMC02ZA After: https://screencast.googleplex.com/cast/NjQ3NDg4MjYyMjY4NTE4NHxhMjUxNjE4YS00ZA I did not re record them, but I did reproduce all the same scenarios successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Redirection on the autocomplete selection from the SV Explorer and Map Explorer (same component):
SV Explorer:
Before: https://screencast.googleplex.com/cast/NTg2NzQ1ODIxNTgwNDkyOHxlNmY4Y2RiMy0wOQ
After: https://screencast.googleplex.com/cast/NTI2ODYzMjQ2NzY2ODk5MnxmNDg0Mzk2NC05Nw
Map Explorer:
Before: https://screencast.googleplex.com/cast/NTI5MDk5NzE2NzY4NTYzMnw4OTAxMWQxMC02ZA
After: https://screencast.googleplex.com/cast/NTI2ODYzMjQ2NzY2ODk5MnxmNDg0Mzk2NC05Nw