Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IN-4716] Make build deploy run sequencially #84

Merged
merged 3 commits into from
May 7, 2024

Conversation

kennyshittu
Copy link
Contributor

We've one more fix to go 😬 . #83 fixed the issue with Install AWS Cli step. We're running into another issue where service-worker.js is missing in build output, this is happening cos we now use a newer version of react-scripts 5.x.x. This PR fixes that as recommended here. adjusted the build_and_deploy_main jobs to run sequential.

Did a complete dry run here :

https://app.circleci.com/pipelines/github/datadotworld/chart-builder/218/workflows/d71508d0-6121-40d5-aafa-e905bb82f340?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary

@kennyshittu kennyshittu merged commit 398cd99 into main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants