Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAP-34] Update python SDK to remove information about searching using resource_id #130

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

nikhilhegde-ddw
Copy link
Contributor

@nikhilhegde-ddw nikhilhegde-ddw requested a review from jonaf March 30, 2022 05:14
Copy link

@jonaf jonaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine; did we test it out manually? Are there any unit tests we should add/update?

@nikhilhegde-ddw
Copy link
Contributor Author

Yes, tested it manually. Now passing resource_id arg to search_resources gets ignored instead of returning the error.
Since resource_id arg is not supported in searching anymore and we are removing it as arg to search_resources, felt new unit test was not needed. Current unit test doesn't need any update it uses only required argument 'query' and was not using any optional arg and resource_id was a optional arg.

@nikhilhegde-ddw nikhilhegde-ddw merged commit a4ce569 into main Mar 31, 2022
ddw-mike added a commit that referenced this pull request Oct 11, 2022
* Update python sdk (#120)

* Update swagger generated API files

* Update authentication method to token

* Fix oauth and switch to new swagger file

* update comment in configuration.py with link to issue

* Implement search endpoint

* Format files according to flake8

* disable failing test

* remove support for python 2.7 (Deprecated)

* update readme and contributing docs

* increment version number in __init__.py file

Co-authored-by: Danial Betres <danialbetres@Danials-MacBook-Pro.local>

* Add table and connection endpoints (#121)

* Update references to new main branch (#123)

* Change doc html name to match GitHub expectation (#124)

* Update DOCTYPE format to fix GitHub pages build (#125)

* Fix to install the python sdk with pandas for python version > 3.7 (#128)

* Fix to install the python sdk with pandas for python version >= 3.7

* Updated circle ci to use pyenv-tox:1.0.0 docker image

* Update circle ci config to setup pyenv 3.7.12 3.8.12 3.9.10 3.10.2

* Updated classifiers

* [PAP-174] python SDK uses an older version of click library (#129)

* [PAP-34] Update python SDK to remove information about searching using resource_id (#130)

* PAPPY-277: Remove outdated file functionality (new PR) (#133)

* PAPPY-277: remove file upload functionality from update_dataset, replace_dataset, update_project, and replace_project; remove unnecessary parameter from __build_dataset_obj and __build_project_obj

* PAPPY-277: Add back file functionality to create_dataset, create_project, and replace_project

* PAPPY-277: Update create, patch, and put APIs for datasets and projects

* PAPPY-277: Update dataset and project request models

* PAPPY-277: Remove file functionality from replace_project

* PAPPY-277: Replace dummy lambdas with method overloading

* PAPPY-277: Support method overloading with multipledispatch

* PAPPY-277: Rename duplicate methods

* PAPPY-277: Remove if statements in builders (with files)

* PAPPY-277: Remove duplicate code

* PAPPY-277: Fix method calls

* PAPPY-277: Fix line length

* PAPPY-277: Fix static method calls

* PAPPY-277: Re-add 'DISCOVERABLE' visibility for datasets

Co-authored-by: Danial Betres <danial.betres@data.world>
Co-authored-by: Danial Betres <danialbetres@Danials-MacBook-Pro.local>
Co-authored-by: Danial Betres <dbetres@uwaterloo.ca>
Co-authored-by: Marie Chatfield Rivas <marie.rivas@data.world>
Co-authored-by: nikhilhegde-ddw <96458241+nikhilhegde-ddw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants