Set token in inline config #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflprr
suggested changes
Nov 16, 2017
datadotworld/datadotworld.py
Outdated
| @@ -51,12 +51,13 @@ class DataDotWorld(object): | |||
| REST API client object | |||
| """ | |||
|
|
|||
| def __init__(self, config=None): | |||
| def __init__(self, config=None, **kwargs): | |||
There was a problem hiding this comment.
No need to accept auth_token via kwargs. If a client wanted to pass the token inline, they could just construct an inline config and pass it in the existing config param here (i.e. dw = DataDotWorld(config=InlineConfig(token)))
datadotworld/datadotworld.py
Outdated
| @@ -114,7 +115,8 @@ def query(self, dataset_key, query, query_type="sql", parameters=None): | |||
| raise RuntimeError( | |||
| 'Error executing query: {}'.format(response.content)) | |||
|
|
|||
| def load_dataset(self, dataset_key, force_update=False, auto_update=False): | |||
| def load_dataset(self, dataset_key, force_update=False, auto_update=False, | |||
| **kwargs): | |||
There was a problem hiding this comment.
kwargs doesn't seem to be used here.
datadotworld/__init__.py
Outdated
| config_param = (ChainedConfig() | ||
| if profile == 'default' | ||
| else FileConfig(profile=profile)) | ||
| token = kwargs.get('auth_token') |
There was a problem hiding this comment.
This section could be simplified as:
config_param = (ChainedConfig(config_chain=[
InlineConfig(kwargs.get('auth_token')),
EnvConfig(),
FileConfig()])
if profile == 'default'
else FileConfig(profile=profile))
added 2 commits
November 17, 2017 21:09
rflprr
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.