Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRL version requirement #20

Closed
mjschock opened this issue Mar 27, 2024 · 4 comments
Closed

TRL version requirement #20

mjschock opened this issue Mar 27, 2024 · 4 comments
Labels

Comments

@mjschock
Copy link

Is there a need for trl to be locked to 0.7.6 here? Can it be relaxed to at least allow 0.8.1 which is compatible with transformers >= 4.39?

There's an import that fails otherwise. See huggingface/trl#1415.

@AjayP13
Copy link
Collaborator

AjayP13 commented Mar 27, 2024 via email

@AjayP13 AjayP13 mentioned this issue Mar 27, 2024
@AjayP13 AjayP13 added enhancement New feature or request dependency update labels Mar 27, 2024
@AjayP13
Copy link
Collaborator

AjayP13 commented Mar 27, 2024

@mjschock Looks like it was an easy update to make (no tests breaking), so it's out now. This is now fixed on the latest on PyPI (0.26.0). Let me know if you have any other issues.

@AjayP13 AjayP13 closed this as completed Mar 27, 2024
@mjschock
Copy link
Author

thanks @AjayP13 - it works! =)

@AjayP13
Copy link
Collaborator

AjayP13 commented Mar 27, 2024

Awesome, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants