-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRL version requirement #20
Labels
Comments
Ah, thanks, let me see what I can do to unlock this (will probably get to
it by this weekend).
Temporarily, however, you can manually install DataDreamer first and then
upgrade transformers afterwards as a second install command.
If you need it more urgently, let me know.
…On Tue, Mar 26, 2024 at 8:29 PM Michael Schock ***@***.***> wrote:
Is there a need for trl to be locked to 0.7.6 here
<https://github.com/datadreamer-dev/DataDreamer/blob/main/src/requirements.txt#L30>?
Can it be relaxed to at least allow 0.8.1 which is compatible with transformers
>= 4.39?
There's an import that fails otherwise. See huggingface/trl#1415
<huggingface/trl#1415>.
—
Reply to this email directly, view it on GitHub
<#20>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJHMELLQT6QX6BVH3PUDI3Y2IHIPAVCNFSM6AAAAABFJ5GDJGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDSNJYGEZTCOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Merged
@mjschock Looks like it was an easy update to make (no tests breaking), so it's out now. This is now fixed on the latest on PyPI ( |
thanks @AjayP13 - it works! =) |
Awesome, no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there a need for
trl
to be locked to 0.7.6 here? Can it be relaxed to at least allow 0.8.1 which is compatible withtransformers >= 4.39
?There's an import that fails otherwise. See huggingface/trl#1415.
The text was updated successfully, but these errors were encountered: