Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in the feature to allow for subdomain connector #134

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

btribit
Copy link

@btribit btribit commented Jan 18, 2024

This will be a required change to address this issue:

datadrivers/terraform-provider-nexus#368

The "subdomain" attribute allows for a subdomain connector to be enabled to avoid having to use special http and https ports.

I have a working PR for terraform-provider-nexus. Incoming.

@btribit btribit changed the title WIP: Adding in the feature to a subdomain connector WIP: Adding in the feature to allow for subdomain connector Jan 18, 2024
@btribit btribit changed the title WIP: Adding in the feature to allow for subdomain connector Adding in the feature to allow for subdomain connector Jan 18, 2024
@btribit
Copy link
Author

btribit commented Jan 29, 2024

I noticed this was failing on the pro bits. I have added in so that they are skippable.

Copy link
Member

@anmoel anmoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anmoel anmoel merged commit 73e7b44 into datadrivers:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants