-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mutual authentication via TLS #146
Conversation
Prior to this change, there was no way to pass in a client certificate if you had set up Nexus behind a load balancer with mutual auth configured. This change exposes some new configuration values that allow you to pass in a path to a file on disk containing your client key/cert (which can be in a single file) and optionally a Root CA.
One thing I noted was the lack of a logging library across the client - I didn't want to introduce one, but would have liked to add some helpful error messages for when files can't be found etc. If that's desirable, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shearn89 please rebase your fork, so the tests are working again |
Couldn't get Docker to behave on my laptop so haven't been able to run the full test suite, but the client test passes. If needed I can rebase/squash etc before merge - let me know if there's any further changes needed! @anmoel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shearn89 do you need this only in the go client or also in the terraform provider? |
I'll need it in the TF provider but I have an internal fork that I used to avoid waiting on PRs, so I'll clean that up and raise a PR in that repo shortly. Thanks! |
@shearn89 release v1.12.0 deployed |
Prior to this change, there was no way to pass in a client certificate
if you had set up Nexus behind a load balancer with mutual auth
configured.
This change exposes some new configuration values that allow you to pass
in a path to a file on disk containing your client key/cert (which can
be in a single file) and optionally a Root CA.