Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/0.3.2 #712

Merged
merged 8 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/backend/bisheng/api/services/role_group_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from bisheng.api.services.user_service import UserPayload
from bisheng.api.errcode.user import UserGroupNotDeleteError
from bisheng.api.utils import get_request_ip
from bisheng.api.v1.schemas import resp_200
from bisheng.database.models.assistant import AssistantDao
from bisheng.database.models.flow import FlowDao
from bisheng.database.models.gpts_tools import GptsToolsDao
Expand Down Expand Up @@ -91,15 +92,17 @@ def delete_group(self, request: Request, login_user: UserPayload, group_id: int)
"""删除用户组"""
group_info = GroupDao.get_user_group(group_id)
if not group_info:
return None
return resp_200()

# 判断组下是否还有用户
user_group_list = UserGroupDao.get_group_user(group_id)
if user_group_list:
return UserGroupNotDeleteError.return_resp()
GroupDao.delete_group(group_id)
self.delete_group_hook(request, login_user, group_info)
return resp_200()

def delete_group_hook(self, request: Request, login_user: UserPayload, group_info: int):
def delete_group_hook(self, request: Request, login_user: UserPayload, group_info: Group):
logger.info(f'act=delete_group_hook user={login_user.user_name} group_id={group_info.id}')
# 记录审计日志
AuditLogService.delete_user_group(login_user, get_request_ip(request), group_info)
Expand All @@ -109,8 +112,8 @@ def delete_group_hook(self, request: Request, login_user: UserPayload, group_inf
need_move_resource = []
for one in all_resource:
# 获取资源属于几个组,属于多个组则不用处理, 否则将资源转移到默认用户组
resourece_groups = GroupResourceDao.get_resource_group(ResourceTypeEnum(one.type), one.third_id)
if len(resourece_groups) > 1:
resource_groups = GroupResourceDao.get_resource_group(ResourceTypeEnum(one.type), one.third_id)
if len(resource_groups) > 1:
continue
else:
one.group_id = DefaultGroup
Expand Down
2 changes: 1 addition & 1 deletion src/backend/bisheng/api/v1/usergroup.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async def delete_group(request: Request,

if not login_user.is_admin():
return UnAuthorizedError.return_resp()
return resp_200(RoleGroupService().delete_group(request, login_user, group_id))
return RoleGroupService().delete_group(request, login_user, group_id)


@router.post('/set_user_group',
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="icon" href="/favicon.ico" />
<script src="/node_modules/ace-builds/src-min-noconflict/ace.js" type="text/javascript"></script>
<%- aceScriptSrc %>
<title>BISHENG</title>
</head>

Expand Down
Loading