Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial support for GraalVM Native images. #1376

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Oct 13, 2024

No description provided.

Copy link

what-the-diff bot commented Oct 13, 2024

PR Summary

  • Introduction of Native Image Support Section in Documentation
    An update has been made to the README.md file. This new section discusses support for native image creation, a feature which is considered experimental as of version 2.4.1 of the Datafaker software.

  • Instructions for Manual Creation of reachability-metadata.json File
    The pull request also includes a detailed, step-by-step guide on how to manually create the reachability-metadata.json file. This file is essential to the native-image process.

  • Reference to a Practical Example on GitHub
    To further illustrate the process, a reference link to an example usage of this feature on GitHub has been provided. This will help users in understanding the application of these instructions in a real-world scenario.

  • Plans for Future Enhancements
    Lastly, the update mentions future plans to automate and enhance the native-image process. This shows a commitment to improving the user experience and making the software more user-friendly.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (330b2b6) to head (ed411eb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1376      +/-   ##
============================================
+ Coverage     92.32%   92.40%   +0.08%     
- Complexity     3146     3148       +2     
============================================
  Files           319      319              
  Lines          6178     6178              
  Branches        604      604              
============================================
+ Hits           5704     5709       +5     
+ Misses          330      326       -4     
+ Partials        144      143       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what's happening here, but looks good. :)

@bodiam
Copy link
Contributor Author

bodiam commented Oct 15, 2024

GraalVM likes statically compiled things, and doesn't like reflection and resource loading much, since it's too dynamic. So when you use Graal with a library which depends on dynamic resource loading, you have to tell Graal which resources will be used. Since that's quite tedious, you can use some tool to generate these mappings for you, and bundle then with the library, so Graalvm doesn't have to be configured anymore.

It could be that I missed a few files though, so no promises that it works 100%!

@bodiam bodiam merged commit eb64c33 into main Oct 15, 2024
12 checks passed
@bodiam bodiam deleted the native-support branch October 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants