Adding support for Tamil language

[sann3]

PR to fix #1377

[what-the-diff]

PR Summary

• Introduction of Tamil Language Support
  We've added support for the Tamil language in our system, now listed as a supported locale in the README.md file.
• New Tamil Language Data File
  A new file named ta.yml has been created. This file is essentially a detailed portfolio of Tamil language data. It includes the specifics for various fields such as names, addresses, companies, and phone number formats. This will make our system more accessible to Tamil-speaking users.

[asolntsev]

@sann3 Thank you for the PR. Generally looks good, but I would ask for few improvements.

1. Typo in commit message: "Create confiog for Tamil language"
2. "ta" is a language used in multiple countries. While "+91" is India country code.
   So the "phone" section should be in file src/main/resources/_IN.yml. Phone is related to country, not language.

[kingthorin]

05:50:20.864 [ERROR] LocalityTest.allSupportedLocales:35 [Somebody forgot to add the new locale to Locality.LOCALES]

[sann3]

Updated the PR with recommended changes, pls check.

[kingthorin]

@asolntsev

2. "ta" is a language used in multiple countries. While "+91" is India country code.
   So the "phone" section should be in file `src/main/resources/_IN.yml`. Phone is related to country, not language.

Same for address?

[asolntsev]

address

Not exactly.
For example, two-letter state codes should be in country gile, but state name, city names etc. should be in the language file because they sound differently in different languages.

[asolntsev]

@sann3 Please execute mvn test, and you will see some failing tests

mvn test
FakerIntegrationTest.testAllFakerMethodsThatReturnStrings:100->testAllMethodsThatReturnStringsActuallyReturnStrings:122 Runtime Test for method public java.lang.String net.datafaker.providers.base.Name.fullName() and object Name(Faker@955ae44)@481a64f2 was failed for locale ta [thread: FakerIntegrationTest.testAllFakerMethodsThatReturnStrings#20438#]

The reason is that this variable is not defined in ta.yml:

         - "#{female_last_name}"

[bodiam]

Hi @sann3 , looks great, thanks. Few things:

• The file needs to be called ta-IN.yml.
• In the file, please change the name: field to this:

      name:
        - "#{male_first_name}"
        - "#{female_first_name}"

When both items have been done, we can merge the PR!

[asolntsev]

• The file needs to be called ta-IN.yml.

Not exactly.

• Language-specific parts in ta.yml, and
• country-specific parts in _IN.yml

See last section in CONTRIBUTING.md

[sann3]

FakerIntegrationTest.testAllFakerMethodsThatReturnStrings test is failing with " Error type: NOT_A_NUMBER. The string supplied did not seem to be a phone number."

If I rename to ta-IN.yml, all the tests are passing. What should I do ?

[asolntsev]

@sann3 All good, I've merged your PR and made few changes in a new PR https://github.com/datafaker-net/datafaker/pull/1385/commits

That was not trivial because of some legacy and hacks in DF code. :)

[sann3]

Can someone pleas add hacktoberfest-accepted label for this pr

[asolntsev]

Em... why? This PR is already merged.

[sann3]

So that it will be counted against the my hacktoberfest Pr count.

[asolntsev]

ah, I got it. Added the label. :)

[sann3]

Thank you