Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add places from Greece for University provider #1399

Merged

Conversation

gvrettos
Copy link
Contributor

Nothing fancy, I just added some places from Greece under universities. I used this as a reference by selecting some main known places out of my knowledge.

Copy link

what-the-diff bot commented Oct 23, 2024

PR Summary

  • Expansion of english localization file
    The university.yml file has been updated to include additional cities in Greece. These additions will allow for a broader recognition and representation of Greek cities within our software. The newly added locations consist of: Athens, Corfu, Heraklion, Ioannina, Komotini, Kozani, Mytilene, Patras, Piraeus, Rethymno, Thessaloniki, Tripoli, and Volos.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (848dfe7) to head (af7f029).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1399      +/-   ##
============================================
+ Coverage     92.19%   92.31%   +0.11%     
- Complexity     3151     3154       +3     
============================================
  Files           319      319              
  Lines          6152     6152              
  Branches        593      593              
============================================
+ Hits           5672     5679       +7     
+ Misses          336      331       -5     
+ Partials        144      142       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asolntsev asolntsev merged commit 66b92f6 into datafaker-net:main Oct 23, 2024
12 checks passed
@asolntsev
Copy link
Collaborator

@gvrettos Thank you for the PR! Looks good.

@gvrettos gvrettos deleted the feature/university-places-greek branch October 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants