-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix generate sql will be truncate when quote char in word #1402
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shanjuren Could you please add a test? Probably in SqlTest.java
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
============================================
+ Coverage 92.19% 92.30% +0.11%
- Complexity 3151 3153 +2
============================================
Files 319 319
Lines 6152 6149 -3
Branches 593 591 -2
============================================
+ Hits 5672 5676 +4
+ Misses 336 332 -4
+ Partials 144 141 -3 ☔ View full report in Codecov by Sentry. |
OK,i will try do it |
is done |
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
I fixed up the PR, I'll merge it in. |
Some thesaurus`s word will be truncate when I use datafaker to generate SQL, like Address,Book... That reason is when SqlTransformer calling the handledObjectToString method will be one by one add char to new Object ,but if miss quote char will be stop.