Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test method name in MovieTest #209

Merged

Conversation

Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Jun 8, 2022

In #208, I named my test method as testName instead of testQuote. This pr fixes it.

@Tahanima
Copy link
Contributor Author

Tahanima commented Jun 8, 2022

The test failure happens for net.datafaker.CNPJTest.

@codecov-commenter
Copy link

Codecov Report

Merging #209 (59870d7) into master (7568c4a) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
- Coverage     94.63%   94.53%   -0.11%     
+ Complexity     1833     1832       -1     
============================================
  Files           186      186              
  Lines          3859     3859              
  Branches        387      387              
============================================
- Hits           3652     3648       -4     
- Misses          105      108       +3     
- Partials        102      103       +1     
Impacted Files Coverage Δ
src/main/java/net/datafaker/Commerce.java 88.46% <0.00%> (-7.70%) ⬇️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bodiam bodiam merged commit 79f0646 into datafaker-net:master Jun 9, 2022
@Tahanima Tahanima deleted the change-movie-test-method-name branch June 15, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants