Add filter ratio dynamic metric #24
Conversation
| const filterRatio = ((totalInputRows - outputRows) / totalInputRows) * 100; | ||
| if(filterRatio <= 100){ | ||
| updatedMetrics.push({ | ||
| name: "filter_ratio", |
There was a problem hiding this comment.
Name should be readable, i.e. "Filter Ratio"
| } | ||
|
|
||
| let totalInputRows = 0; | ||
| let validPredecessors = 0; |
There was a problem hiding this comment.
This is redundant, you can just check if input rows is 0
| return updatedMetrics; | ||
| } | ||
|
|
||
| const filterRatio = ((totalInputRows - outputRows) / totalInputRows) * 100; |
There was a problem hiding this comment.
use formatPercentage util method
There was a problem hiding this comment.
Also "filter ratio" is the opposite I think, if you filter 1000 from 1M it's 0.1% filtered not 99%. Maybe the naming should be better here like "filtered rows percentage"
| @@ -399,6 +400,7 @@ export function updateSqlNodeMetrics( | |||
|
|
|||
| const notEffectedSqls = currentStore.sqls.filter((sql) => sql.id !== sqlId); | |||
| const runningSql = runningSqls[0]; | |||
| const graph = generateGraph(runningSql.edges, runningSql.nodes); | |||
There was a problem hiding this comment.
This means we are generating the graph for every metric update cycle. This is not ideal.
We should cache the graph if there is no change.
Please at least add a todo comment to cache the graph.
| ): EnrichedSqlMetric[] { | ||
|
|
||
| const updatedMetrics = calcNodeMetrics(node.type, metrics); | ||
| addFilterRatioMetric(node, updatedMetrics, graph, allNodes); |
There was a problem hiding this comment.
you return updatedMetrics and does nothing with it.
We prefer to be functional, so add the new metric and with [..., newMetric"] and return this from the method
were replaced with updateNodeMetrics function.